Skip to content

added Faq page. resolved issue #29 https://github.com/yashksaini-coder/Leetcode-Journal/issues/29 #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 8, 2025
Merged

added Faq page. resolved issue #29 https://github.com/yashksaini-coder/Leetcode-Journal/issues/29 #32

merged 4 commits into from
Jan 8, 2025

Conversation

@JAYANTJOSHI001
Copy link
Contributor

@JAYANTJOSHI001 JAYANTJOSHI001 commented Jan 8, 2025

Pull Request Template

Summary

made faq section.
made a different footer component
updated ui of header page in file navbar.jsx(if needed, lmk i will add it to full website, till now it is only for faq page)
faq-light
faq-dark

Fixes # (issue)

Type of Change

Please mark [X] for applicable items:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] Documentation update
  • [] Code refactoring
  • [] Other (please describe):

Testing

Please describe the tests you performed to verify your changes:

Screenshots/Videos

Please attach relevant screenshots or videos demonstrating the changes.

Checklist

Please mark [X] for completed items:

  • My code follows the project's style guidelines
  • I have performed a self-review of my code
  • [] I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@JAYANTJOSHI001
added faq page
fe42d44 
updated navbar
added footer
added contact sectiom

Signed-off-by: JAYANTJOSHI001 <jayantjoshi909@gmail.com>
@JAYANTJOSHI001
Merge branch 'main' of https://github.com/yashksaini-coder/Leetcode-J…
ee0872a 
…ournal

Signed-off-by: JAYANTJOSHI001 <jayantjoshi909@gmail.com>
@JAYANTJOSHI001
added new feature
fd74aa9 
Signed-off-by: JAYANTJOSHI001 <jayantjoshi909@gmail.com>
@vercel
Copy link

vercel bot commented Jan 8, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
leetcode-journal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2025 0:18am

@github-actions
Copy link

github-actions bot commented Jan 8, 2025

Welcome, new contributor!

   Please make sure you've read our [Contributing Guide](README.md) and we look forward to reviewing your Pull request shortly ✨

@JAYANTJOSHI001 JAYANTJOSHI001 changed the title added Faq page. resolved issue #29 added Faq page. resolved issue #29 https://github.com/yashksaini-coder/Leetcode-Journal/issues/29 Jan 8, 2025
yashksaini-coder
yashksaini-coder reviewed Jan 8, 2025
View reviewed changes
components/navbar.jsx
Copy link
Owner

@yashksaini-coder yashksaini-coder Jan 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JAYANTJOSHI001 Kindly use the Typescript file .tsx.

yashksaini-coder
yashksaini-coder reviewed Jan 8, 2025
View reviewed changes
yashksaini-coder
yashksaini-coder reviewed Jan 8, 2025
View reviewed changes
yashksaini-coder
yashksaini-coder reviewed Jan 8, 2025
View reviewed changes
yashksaini-coder
yashksaini-coder requested changes Jan 8, 2025
View reviewed changes
Copy link
Owner

@yashksaini-coder yashksaini-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JAYANTJOSHI001 Kindly complete the requested changes

@yashksaini-coder yashksaini-coder added enhancement New feature or request SWOC officially part of SWOC season 5 Intermediate SWOC Level 2 issue Under Review The Pull Request is under Review Changes requested Changes are requested labels Jan 8, 2025
@yashksaini-coder yashksaini-coder mentioned this pull request Jan 8, 2025
Closed
@JAYANTJOSHI001
made changes in the contact section and added a
4aa7271 
new page for FAQ

Signed-off-by: JAYANTJOSHI001 <jayantjoshi909@gmail.com>
@vercel
Copy link

vercel bot commented Jan 8, 2025

@JAYANTJOSHI001 is attempting to deploy a commit to the Yash Kumar Saini's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link

github-actions bot commented Jan 8, 2025

Welcome, new contributor!

   Please make sure you've read our [Contributing Guide](README.md) and we look forward to reviewing your Pull request shortly ✨

yashksaini-coder
yashksaini-coder approved these changes Jan 8, 2025
View reviewed changes
Copy link
Owner

@yashksaini-coder yashksaini-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the changes are completed. great work @JAYANTJOSHI001

@yashksaini-coder yashksaini-coder merged commit 6f4baeb into yashksaini-coder:main Jan 8, 2025
3 checks passed
@yashksaini-coder yashksaini-coder added Points Assigned The points have been assigned on OS Lead and removed Under Review The Pull Request is under Review Changes requested Changes are requested labels Jan 8, 2025
@yashksaini-coder yashksaini-coder mentioned this pull request Jan 8, 2025
Closed
yashksaini-coder
yashksaini-coder reviewed Jan 8, 2025
View reviewed changes
Copy link
Owner

@yashksaini-coder yashksaini-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yashksaini-coder yashksaini-coder yashksaini-coder approved these changes

Assignees

@JAYANTJOSHI001 JAYANTJOSHI001

Labels

enhancement New feature or request Intermediate SWOC Level 2 issue Points Assigned The points have been assigned on OS Lead SWOC officially part of SWOC season 5

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JAYANTJOSHI001 @yashksaini-coder